-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add benchmark tests to CI runs #34288
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@nodejs/testing |
@nodejs/build @nodejs/collaborators This is ready to go, I think, but needs some approvals/reviews. |
Landed in c7627da |
This is causing test failures when landed on v14.x. Would you be willing to open a backport? |
Closes: nodejs#34321 PR-URL: nodejs#34288 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Not sure where the CI results for this on 14.x are, so running this: https://ci.nodejs.org/job/node-test-commit/39653/ Mostly a note to self for later. |
No related test failures, I don't think. (One seemingly-unrelated macOS failure.) @MylesBorins Does this still need a backport or anything? Or can it go in as-is? |
Closes: #34321 PR-URL: #34288 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Closes: #34321 PR-URL: #34288 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Closes: #34321 PR-URL: #34288 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Closes: #34321 PR-URL: #34288 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Closes: #34321 PR-URL: #34288 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes