Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: allow promisified exec to be cancel #34249

Closed
wants to merge 25 commits into from
Closed

child_process: allow promisified exec to be cancel #34249

wants to merge 25 commits into from

Commits on Jan 12, 2021

  1. child_process: allow promisified exec to be cancel 

    Using new experimental AbortController, add support for promisified
exec to be cancelled.
    @metcoder95
    metcoder95 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    eed3f17 View commit details
    Browse the repository at this point in the history

  2. child_process: fix validation issue 

    When doing a validation for the signal object, the validation was
assuming wrongly that the signal object will always be there to apply
the correct event-listener. The fix does a better validation to avoid
fall in "addEventListener is not a function"
    @metcoder95
    metcoder95 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    0ef841d View commit details
    Browse the repository at this point in the history

  3. child_process: use Primordials instead of plain Promise

    @metcoder95
    metcoder95 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    70cb86c View commit details
    Browse the repository at this point in the history

  4. child_process: refactor according to review

    @metcoder95
    metcoder95 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    a6ae623 View commit details
    Browse the repository at this point in the history

  5. child_process: remove license from test

    @metcoder95
    metcoder95 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    988ea3f View commit details
    Browse the repository at this point in the history

  6. child_process: improve testing

    @metcoder95
    metcoder95 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    78e7521 View commit details
    Browse the repository at this point in the history

  7. child_process: fix linter issues

    @metcoder95
    metcoder95 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    c8210f6 View commit details
    Browse the repository at this point in the history

  8. child_process: check if AbortSignal is aborted before rejecting/resol… 

    …ving
    @metcoder95
    metcoder95 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    3dca212 View commit details
    Browse the repository at this point in the history

  9. child_process: check for signal before looking is aborted

    @metcoder95
    metcoder95 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    4163c44 View commit details
    Browse the repository at this point in the history

  10. child_process: refactor signal to use spawn function

    @metcoder95
    metcoder95 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    9e3291e View commit details
    Browse the repository at this point in the history

  11. child_process: fix linter issues

    @metcoder95
    metcoder95 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    3b14ebe View commit details
    Browse the repository at this point in the history

  12. child_process: revert check for extra callback

    @metcoder95
    metcoder95 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    087f924 View commit details
    Browse the repository at this point in the history

  13. child_process: fix double AbortError emit

    @metcoder95
    metcoder95 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    0fd0719 View commit details
    Browse the repository at this point in the history

  14. child_process: fix linter issues

    @metcoder95
    metcoder95 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    a41ac9a View commit details
    Browse the repository at this point in the history

  15. child_process: fix fork issue with AbortController

    @metcoder95
    metcoder95 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    f9af3fd View commit details
    Browse the repository at this point in the history

  16. child_process: remove whitespace

    @metcoder95
    metcoder95 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    2b19cd5 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2021

  1. child_process: re-order alphabetically the options

    @metcoder95
    metcoder95 committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    f642015 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2021

  1. child_process: refactor spawnWithSignal

    @metcoder95
    metcoder95 committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    dade71b View commit details
    Browse the repository at this point in the history

  2. child_process: remove wrapper function

    @metcoder95
    metcoder95 committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    5e7aa7d View commit details
    Browse the repository at this point in the history

  3. child_process: revert refactor to spawn

    @metcoder95
    metcoder95 committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    2305734 View commit details
    Browse the repository at this point in the history

  4. child_process: fix tests

    @metcoder95
    metcoder95 committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    a60b935 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. child_process: refactor

    @metcoder95
    metcoder95 committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    fe077b0 View commit details
    Browse the repository at this point in the history

  2. child_process: refactor tests

    @metcoder95
    metcoder95 committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    72ff68a View commit details
    Browse the repository at this point in the history

  3. child_process: refactor listeners args

    @metcoder95
    metcoder95 committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    026021a View commit details
    Browse the repository at this point in the history

  4. child_process: inline listener

    @metcoder95
    metcoder95 committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    c093035 View commit details
    Browse the repository at this point in the history