Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: remove redundant cast #34086

Closed
wants to merge 1 commit into from
Closed

quic: remove redundant cast #34086

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Jun 27, 2020
@jasnell
Copy link
Member

jasnell commented Jun 27, 2020

Hmm... quick side note in that the CODEOWNERS file does not appear to be working...

@jasnell
Copy link
Member

jasnell commented Jun 27, 2020

QUIC CI: https://ci.nodejs.org/job/node-test-commit/39325/

@gengjiawen gengjiawen mentioned this pull request Jun 30, 2020
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32153/

jasnell pushed a commit that referenced this pull request Jun 30, 2020
@gengjiawen @jasnell
quic: remove redundant cast
68634d2 
PR-URL: #34086
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jun 30, 2020

Landed in 68634d2

@jasnell jasnell closed this Jun 30, 2020
@gengjiawen gengjiawen deleted the redundant_cast branch July 1, 2020 01:16
@MylesBorins
Copy link
Contributor

Marked as "backport-requested" because I do not believe quic is on 14.x yet. Should we change the label to "dont-land"?

@gengjiawen
Copy link
Member Author

Marked as "backport-requested" because I do not believe quic is on 14.x yet. Should we change the label to "dont-land"?

Yeap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHeer MrHeer MrHeer approved these changes

@devnexen devnexen devnexen approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gengjiawen @jasnell @nodejs-github-bot @MylesBorins @devnexen @MrHeer @targos