Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "repl: always check for NODE_REPL_MODE environment variable" #34058

Closed
wants to merge 1 commit into from

Commits on Jun 26, 2020

  1. Revert "repl: always check for NODE_REPL_MODE environment variable"

    This reverts commit b831b08.
    
    This presumably unbreaks the ASAN github action build.
    
    Example failure:
    
        2020-06-25T19:59:15.1448178Z === release test-repl-envvars ===
        2020-06-25T19:59:15.1448872Z Path: parallel/test-repl-envvars
        2020-06-25T19:59:15.1449449Z --- stderr ---
        2020-06-25T19:59:15.1449835Z assert.js:103
        2020-06-25T19:59:15.1450194Z   throw new AssertionError(obj);
        2020-06-25T19:59:15.1450524Z   ^
        2020-06-25T19:59:15.1450817Z
        2020-06-25T19:59:15.1451431Z AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
        2020-06-25T19:59:15.1452000Z + actual - expected
        2020-06-25T19:59:15.1452298Z
        2020-06-25T19:59:15.1452634Z   {
        2020-06-25T19:59:15.1452978Z     terminal: true,
        2020-06-25T19:59:15.1453321Z +   useColors: false
        2020-06-25T19:59:15.1453861Z -   useColors: true
        2020-06-25T19:59:15.1454225Z   }
        2020-06-25T19:59:15.1454841Z     at /home/runner/work/node/node/test/parallel/test-repl-envvars.js:55:12
        2020-06-25T19:59:15.1455246Z     at internal/repl.js:33:5
    addaleax committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    4697c29 View commit details
    Browse the repository at this point in the history