Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove manual exception handling in queueMicrotask #33859

Closed
wants to merge 2 commits into from
Closed

lib: remove manual exception handling in queueMicrotask #33859

wants to merge 2 commits into from

Commits on Jun 12, 2020

  1. deps: V8: cherry-pick 767e65f945e7 

    Original commit message:

    [API] Fix microtask message reporting

    RunSingleMicrotask calls Runtime::ReportMessage, but the implementation
    of ReportMessage would unconditionally discard these exceptions. This
    CL removes all of the intermediate logic and directly calls
    MessageHandler::ReportMessage, restoring the ability of
    RunSingleMicrotask to report exceptions that occur in microtasks.

    Bug: v8:8326
    Change-Id: I493de74383b2ab191d786611fb9eba9d27e7a243
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2162121
    Commit-Queue: Gus Caplan <[email protected]>
    Reviewed-by: Jakob Gruber <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#67630}

Refs: v8/v8@767e65f
    @devsnek
    devsnek committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    ce4d184 View commit details
    Browse the repository at this point in the history

  2. lib: remove manual exception handling in queueMicrotask

    @devsnek
    devsnek committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    b9f5307 View commit details
    Browse the repository at this point in the history