doc: fix typo in cli.md for report-dir #33725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the missing backtick in `--report-dir` refs: nodejs#33587 (comment)
nodejs-github-bot
added
cli
richardlau
approved these changes
Jun 4, 2020
richardlau
added
the
author ready
BethGriggs
approved these changes
Jun 4, 2020
gireeshpunathil
approved these changes
Jun 4, 2020
himself65
approved these changes
Jun 4, 2020
cjihrig
approved these changes
Jun 4, 2020
jasnell
approved these changes
Jun 4, 2020
|
👍 to fast track |
lpinca
approved these changes
Jun 4, 2020
jasnell
pushed a commit
that referenced
this pull request
Jun 4, 2020
Add the missing backtick in `--report-dir` refs: #33587 (comment) PR-URL: #33725 Refs: #33587 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 641c466 |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
Add the missing backtick in `--report-dir` refs: #33587 (comment) PR-URL: #33725 Refs: #33587 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Add the missing backtick in `--report-dir` refs: #33587 (comment) PR-URL: #33725 Refs: #33587 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Add the missing backtick in `--report-dir` refs: #33587 (comment) PR-URL: #33725 Refs: #33587 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed a backtick in #33587, adding it back.
refs: #33587 (comment)
Checklist