Skip to content

src: simplify Reindent function in json_utils.cc #33722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sapics wants to merge 2 commits into from
Closed

src: simplify Reindent function in json_utils.cc #33722

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc0fcf8
src: simplify Reindent function in json_utils.cc
sapics Jun 4, 2020
4738605
fix indent error reported by lint
sapics Jun 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/json_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,11 @@ std::string EscapeJsonChars(const std::string& str) {
}

std::string Reindent(const std::string& str, int indent_depth) {
std::string indent;
for (int i = 0; i < indent_depth; i++) indent += ' ';

if (indent_depth <= 0) return str;
const std::string indent(indent_depth, ' ');
std::string out;
std::string::size_type pos = 0;
do {
for (;;) {
std::string::size_type prev_pos = pos;
pos = str.find('\n', pos);

Expand All @@ -59,7 +58,7 @@ std::string Reindent(const std::string& str, int indent_depth) {
pos++;
out.append(str, prev_pos, pos - prev_pos);
}
} while (true);
}

return out;
}
Expand Down