Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix node.gyp config #33685

Closed
wants to merge 1 commit into from
Closed

build: fix node.gyp config #33685

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

This lead to weird config bug on windows.

@gengjiawen gengjiawen requested a review from jasnell June 1, 2020 15:47
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jun 1, 2020
@gengjiawen gengjiawen mentioned this pull request Jun 1, 2020
Closed
@addaleax
Copy link
Member

addaleax commented Jun 1, 2020

👍 to fast-tracking

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 1, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31687/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31691/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31692/

@targos targos self-assigned this Jun 2, 2020
@targos
Copy link
Member

targos commented Jun 2, 2020

Landed in 81f6dd6

targos pushed a commit that referenced this pull request Jun 2, 2020
@gengjiawen @targos
build: fix node.gyp config
81f6dd6 
PR-URL: #33685
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos closed this Jun 2, 2020
@gengjiawen gengjiawen deleted the gyp_fix branch June 2, 2020 08:46
This was referenced Jun 4, 2020
Closed
Open
Open
Open
Open
Open
Open
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@gengjiawen @codebytere
build: fix node.gyp config
7a4c689 
PR-URL: #33685
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@gengjiawen @codebytere
build: fix node.gyp config
73c3f7c 
PR-URL: #33685
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@codebytere
Copy link
Member

Backport blocked on #33291

@targos targos removed their assignment Oct 31, 2021
This was referenced May 22, 2023
Open
Open
Open
@137717unity 137717unity mentioned this pull request May 22, 2023
Open
@snyk-bot snyk-bot mentioned this pull request May 23, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request May 24, 2023
Open
@baby636 baby636 mentioned this pull request May 24, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 25, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Nov 28, 2023
Open
@baby636 baby636 mentioned this pull request Nov 28, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Dec 19, 2023
Open
@137717unity 137717unity mentioned this pull request Dec 19, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Dec 19, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Dec 19, 2023
Open
@baby636 baby636 mentioned this pull request Dec 20, 2023
Open
@137717unity 137717unity mentioned this pull request Apr 14, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Apr 14, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Apr 14, 2024
Open
@molllyn1 molllyn1 mentioned this pull request Apr 14, 2024
Open
@kissofire kissofire mentioned this pull request Apr 14, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Apr 14, 2024
Open
@baby636 baby636 mentioned this pull request Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@devsnek devsnek devsnek approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gengjiawen @addaleax @nodejs-github-bot @targos @codebytere @cjihrig @richardlau @devsnek