tools: update dependencies for markdown linting #33412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
May 15, 2020
Trott
added
the
author ready
|
(Code changes here only get run in lint jobs, so full CI should be superfluous.) |
richardlau
approved these changes
May 15, 2020
Add a comment to disable a rule in the 14.x changelog that will be needed once we update remark lint dependencies. This comment appears in the other changelogs. Refs: nodejs/remark-preset-lint-node#89 (comment) PR-URL: nodejs#33412 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: nodejs#33412 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
Landed in b46bbf2...b3ca886 |
codebytere
pushed a commit
that referenced
this pull request
May 17, 2020
Add a comment to disable a rule in the 14.x changelog that will be needed once we update remark lint dependencies. This comment appears in the other changelogs. Refs: nodejs/remark-preset-lint-node#89 (comment) PR-URL: #33412 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
May 17, 2020
PR-URL: #33412 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
PR-URL: #33412 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
codebytere
pushed a commit
to codebytere/node
that referenced
this pull request
Jun 9, 2020
PR-URL: nodejs#33412 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tools: update dependencies for markdown linting
Also:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes