Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: stream: mutable highWaterMark and objectMode #33342

Closed
wants to merge 2 commits into from
Closed

WIP: stream: mutable highWaterMark and objectMode #33342

wants to merge 2 commits into from

Conversation

0807Jpatel
Copy link

added methods to update highWaterMark and objectMode values of Readable and Writable streams.
Refs: #32731
Can also be used for following: #30107

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label May 10, 2020
@0807Jpatel 0807Jpatel changed the title stream: mutable highWaterMark and objectMode WIP: stream: mutable highWaterMark and objectMode May 10, 2020
@0807Jpatel 0807Jpatel closed this May 10, 2020
@0807Jpatel 0807Jpatel deleted the feat/mutable_HWM branch May 10, 2020 18:48
@0807Jpatel 0807Jpatel restored the feat/mutable_HWM branch May 10, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0807Jpatel @nodejs-github-bot