Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add Uint8Array to end and write #33217

Closed
wants to merge 1 commit into from
Closed

doc: add Uint8Array to end and write #33217

wants to merge 1 commit into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented May 2, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels May 2, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 3, 2020
@SimonSchick
Copy link
Contributor

Hey just chiming in, since Buffer inherits from Uint8Array shouldn't the param just be Uint8Array | string?

@addaleax
Copy link
Member

addaleax commented May 4, 2020

@SimonSchick Yes. Lots of people don’t know that Buffer inherits from Uint8Array, so that’s why (I believe) we’ve been documenting this explicitly.

@SimonSchick
Copy link
Contributor

Right, maybe the class hierarchies should be documented more clearly at some point.
I've only commented cause I tried to clean those type unions up in @types/node 😛

@addaleax
Copy link
Member

addaleax commented May 7, 2020

Landed in 280c485

addaleax pushed a commit that referenced this pull request May 7, 2020
@rexagod @addaleax
doc: add Uint8Array to end and write
280c485 
PR-URL: #33217
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@addaleax addaleax closed this May 7, 2020
codebytere pushed a commit that referenced this pull request May 11, 2020
@rexagod @codebytere
doc: add Uint8Array to end and write
5b42d81 
PR-URL: #33217
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@rexagod @codebytere
doc: add Uint8Array to end and write
8b44be9 
PR-URL: #33217
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@rexagod @SimonSchick @addaleax @jasnell @lpinca @cjihrig @BridgeAR @aduh95 @trivikr @nodejs-github-bot