Skip to content

http2: [compat api] use Object.create(null) for getHeaders #33188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rexagod wants to merge 5 commits into from
Closed

http2: [compat api] use Object.create(null) for getHeaders #33188

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5f81a3
http2: use `Object.create(null)` for `getHeaders`
rexagod Apr 25, 2020
92d9481
fixup
rexagod May 9, 2020
cc0396d
fixup
rexagod May 9, 2020
ab51769
fixup
rexagod May 24, 2020
9094028
fixup
rexagod May 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/http2/compat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ class Http2ServerResponse extends Stream {
}

getHeaders() {
return { ...this[kHeaders] };
Comment thread
rexagod marked this conversation as resolved.
return this[kHeaders];
}

hasHeader(name) {
Expand Down
5 changes: 3 additions & 2 deletions test/parallel/test-http2-compat-serverresponse-headers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,12 @@ server.listen(0, common.mustCall(function() {
response.setHeader(real, expectedValue);
const expectedHeaderNames = [real];
assert.deepStrictEqual(response.getHeaderNames(), expectedHeaderNames);
const expectedHeaders = { [real]: expectedValue };
const expectedHeaders = Object.create(null);
expectedHeaders[real] = expectedValue;
assert.deepStrictEqual(response.getHeaders(), expectedHeaders);

response.getHeaders()[fake] = fake;
assert.strictEqual(response.hasHeader(fake), false);
assert.strictEqual(response.hasHeader(fake), true);
Comment thread
BridgeAR marked this conversation as resolved.
Outdated

assert.strictEqual(response.sendDate, true);
response.sendDate = false;
Expand Down