Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: bump remark-preset-lint-node to 1.15.0 #33157

Merged
merged 13 commits into from
May 2, 2020
Merged

tools: bump remark-preset-lint-node to 1.15.0 #33157

merged 13 commits into from
May 2, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 30, 2020

New version of remark-preset-lint-node includes prohibited string entry
accidentally removed in the last version.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 30, 2020
@guybedford
module: no type module resolver side effects
2496db8 
PR-URL: nodejs#33086
Reviewed-By: Jan Krems <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
himself65 and others added 3 commits April 30, 2020 11:07
@himself65 @ronag
stream: simplify Readable push/unshift logic
0bd24a6 
PR-URL: nodejs#32899
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@joyeecheung
vm: fix vm.measureMemory() and introduce execution option
5f2c4ce 
nodejs/node-v8#147 broke the
`vm.measureMemory()` API. It only created a `MeasureMemoryDelegate` and
without actually calling `v8::Isolate::MeasureMemory()` so the returned
promise will never resolve. This was not caught by the tests because
the promise resolvers were not wrapped with `common.mustCall()`.

This patch migrates the API properly and also introduce the newly
added execution option to the API. It also removes support for
specifying contexts to measure - instead we'll just return the
measurements for all contexts in the detailed mode, which is
what the `performance.measureMemory()` prototype in V8 currently does.
We can consider implementing our own `v8::MeasureMemoryDelegate`
to select the target context in `ShouldMeasure()` in the future,
but then we'll also need to implement `MeasurementComplete()`
to assemble the result. For now it's probably too early to do that.

Since this API is still experimental (and guarded with a warning),
such breakage should be acceptable.

Refs: nodejs/node-v8#147

PR-URL: nodejs#32988
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ronag
stream: fix stream.finished on Duplex
d84f131 
finished would incorrectly believe that a Duplex is already
closed if either the readable or writable side has completed.

Fixes: nodejs#33130

PR-URL: nodejs#33133
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 30, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31118/

ronag and others added 5 commits April 30, 2020 16:01
@ronag
stream: remove unused _transformState
e10e292 
_transformState is no longer used since Transform was
simplified.

Refs: nodejs#32763

PR-URL: nodejs#33105
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@addaleax @puzpuzpuz
test: move test-process-title to sequential
ab41b98 
This test can fail when run in parallel with test-process-title-cli,
which also sets the process title, which is global state on Windows.

Example failure (note that `foo` does not appear in test-process-title
but in test-process-title-cli):

    not ok 1727 parallel/test-process-title
      ---
      duration_ms: 0.156
      severity: fail
      exitcode: 1
      stack: |-
        assert.js:103
          throw new AssertionError(obj);
          ^

        AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
        + actual - expected

        + 'foo'
        - 'd:\\a\\node\\node\\out\\Release\\node.exe'
            at Object.<anonymous> (d:\a\node\node\test\parallel\test-process-title.js:22:1)
            at Module._compile (internal/modules/cjs/loader.js:1176:30)
            at Object.Module._extensions..js (internal/modules/cjs/loader.js:1196:10)
            at Module.load (internal/modules/cjs/loader.js:1040:32)
            at Function.Module._load (internal/modules/cjs/loader.js:929:14)
            at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
            at internal/main/run_main_module.js:17:47 {
          generatedMessage: true,
          code: 'ERR_ASSERTION',
          actual: 'foo',
          expected: 'd:\\a\\node\\node\\out\\Release\\node.exe',
          operator: 'strictEqual'
        }
      ...

(from https://github.com/nodejs/node/runs/628144750?check_suite_focus=true)

PR-URL: nodejs#33150
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
@addaleax
deps: V8: backport e29c62b74854
4b2d958 
Original commit message:

    [arraybuffer] Clean up BackingStore even if it pointer to nullptr

    For a zero-length BackingStore allocation, it is valid for the
    underlying memory to be a null pointer. However, some cleanup
    is still necessary, since the BackingStore may hold a reference
    to the allocator itself, which needs to be released when destroying
    the `BackingStore` instance.

    Change-Id: I1f168079d39e4592d2fde31fbe5f705586690e85
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2169646
    Reviewed-by: Ulan Degenbaev <[email protected]>
    Commit-Queue: Ulan Degenbaev <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#67420}

Refs: v8/v8@e29c62b

PR-URL: nodejs#33125
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@addaleax
test: skip memory usage tests when ASAN is enabled
d5e1795 
Running tests with an ASAN build leads to increased memory usage,
rendering the memory usage assumptions in the test invalid.

Refs: nodejs#32776 (comment)

PR-URL: nodejs#33129
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@omsmith @ronag
http: set default timeout in agent keepSocketAlive
0413acc 
Previous location of setting the timeout would override
behaviour of custom HttpAgents' keepSocketAlive. Moving
it into the default keepSocketAlive allows it to
interoperate with custom agents.

Fixes: nodejs#33111

PR-URL: nodejs#33127
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31122/

yunnysunny and others added 4 commits April 30, 2020 18:30
@yunnysunny @juanarbol
doc: fix the spelling error in stream.md
e951825 
Change `64kb` to `64KB` in  `stream.md`

PR-URL: nodejs#31561
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@juanarbol @gireeshpunathil
doc: clarify when not to run CI on docs
26477b8 
Collaborators won't need to run CI on documentation-only changes.

PR-URL: nodejs#33101
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
@kevinoid @gireeshpunathil
doc: add util.types.isArrayBufferView()
7c36ec3 
This function was added by nodejs#15663,
but was never documented. This commit documents it.

PR-URL: nodejs#33092
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
@Trott
tools: bump remark-preset-lint-node to 1.15.0
8a2c65a 
New version of remark-preset-lint-node includes prohibited string entry
accidentally removed in the last version.

PR-URL: nodejs#33157
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@Trott Trott merged commit 8a2c65a into nodejs:master May 2, 2020
@Trott
Copy link
Member Author

Trott commented May 2, 2020

Landed in 8a2c65a

targos pushed a commit that referenced this pull request May 4, 2020
@Trott @targos
tools: bump remark-preset-lint-node to 1.15.0
6734cc4 
New version of remark-preset-lint-node includes prohibited string entry
accidentally removed in the last version.

PR-URL: #33157
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos targos mentioned this pull request May 4, 2020
Merged
targos pushed a commit that referenced this pull request May 7, 2020
@Trott @targos
tools: bump remark-preset-lint-node to 1.15.0
1ba09e0 
New version of remark-preset-lint-node includes prohibited string entry
accidentally removed in the last version.

PR-URL: #33157
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this pull request May 7, 2020
@Trott @targos
tools: bump remark-preset-lint-node to 1.15.0
99f3e97 
New version of remark-preset-lint-node includes prohibited string entry
accidentally removed in the last version.

PR-URL: #33157
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos targos mentioned this pull request May 7, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@Trott @targos
tools: bump remark-preset-lint-node to 1.15.0
94e4847 
New version of remark-preset-lint-node includes prohibited string entry
accidentally removed in the last version.

PR-URL: #33157
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.