http: set IncomingMessage.destroyed #33131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IncomingMessage is a Readable stream and should properly set the destroyed property.
|
@nodejs/http @nodejs/web-server-frameworks |
addaleax
approved these changes
Apr 28, 2020
addaleax
added
the
author ready
ronag
added
wip
ronag
force-pushed
the
http-outgoing-destroyed
branch
from
7c5696c
to
39b5d2b
Compare
|
@nodejs/http: I missed a few cases earlier. PTAL. |
juanarbol
approved these changes
Apr 30, 2020
ronag
added
the
author ready
|
Landed in 28e6626 |
addaleax
pushed a commit
that referenced
this pull request
May 9, 2020
IncomingMessage is a Readable stream and should properly set the destroyed property. PR-URL: #33131 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
May 11, 2020
IncomingMessage is a Readable stream and should properly set the destroyed property. PR-URL: #33131 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Merged
This was referenced May 27, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IncomingMessage is a Readable stream and should properly
set the destroyed property.
This code is a little weird in general but this is the best solution I can think of until a bigger refactoring.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes