Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: assign missing deprecation code #33109

Closed
wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

Refs: #32807

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Apr 27, 2020
@richardlau richardlau mentioned this pull request Apr 27, 2020
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to fast-tracking

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 27, 2020
addaleax pushed a commit that referenced this pull request Apr 27, 2020
Signed-off-by: Richard Lau <[email protected]>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@addaleax
Copy link
Member

Landed in 76ba950

@addaleax addaleax closed this Apr 27, 2020
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
Signed-off-by: Richard Lau <[email protected]>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
Signed-off-by: Richard Lau <[email protected]>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
Signed-off-by: Richard Lau <[email protected]>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
Signed-off-by: Richard Lau <[email protected]>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
Signed-off-by: Richard Lau <[email protected]>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants