Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: crypto_common edits #33107

Closed
wants to merge 2 commits into from
Closed

src: crypto_common edits #33107

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Apr 27, 2020

Extracted from the QUIC PR:

Commit 1: Updates UseSNIContext to use BaseObjectPtr
Commit 2: Returns Undefined when validation err == 0. This is currently only used by the QUIC implementation but the change itself is not QUIC specific.

/cc @addaleax @sam-github

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@jasnell
src: crypto::UseSNIContext to use BaseObjectPtr
57c9850 
Extracted from the QUIC PR. Not specific to QUIC.

Signed-off-by: James M Snell <[email protected]>
@jasnell
src: return undefined when validation err == 0
cb3ec20 
Extracted from the QUIC PR. Not specific to QUIC even if the
behavior is currently only used there.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Apr 27, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 27, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/31024/ (:yellow_heart:)

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 28, 2020
jasnell added a commit that referenced this pull request Apr 29, 2020
@jasnell
src: crypto::UseSNIContext to use BaseObjectPtr
7acaf4e 
Extracted from the QUIC PR. Not specific to QUIC.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #33107
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
jasnell added a commit that referenced this pull request Apr 29, 2020
@jasnell
src: return undefined when validation err == 0
ac8dba3 
Extracted from the QUIC PR. Not specific to QUIC even if the
behavior is currently only used there.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #33107
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Apr 29, 2020

Landed in 7acaf4e and ac8dba3

@jasnell jasnell closed this Apr 29, 2020
targos pushed a commit that referenced this pull request May 4, 2020
@jasnell @targos
src: crypto::UseSNIContext to use BaseObjectPtr
f4e5ab1 
Extracted from the QUIC PR. Not specific to QUIC.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #33107
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
targos pushed a commit that referenced this pull request May 4, 2020
@jasnell @targos
src: return undefined when validation err == 0
f61928b 
Extracted from the QUIC PR. Not specific to QUIC even if the
behavior is currently only used there.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #33107
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@targos targos mentioned this pull request May 4, 2020
Merged
targos pushed a commit that referenced this pull request May 7, 2020
@jasnell @targos
src: crypto::UseSNIContext to use BaseObjectPtr
4562d4b 
Extracted from the QUIC PR. Not specific to QUIC.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #33107
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
targos pushed a commit that referenced this pull request May 7, 2020
@jasnell @targos
src: return undefined when validation err == 0
b45c881 
Extracted from the QUIC PR. Not specific to QUIC even if the
behavior is currently only used there.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #33107
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@targos targos mentioned this pull request May 7, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@jasnell @targos
src: crypto::UseSNIContext to use BaseObjectPtr
1436977 
Extracted from the QUIC PR. Not specific to QUIC.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #33107
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
targos pushed a commit that referenced this pull request May 13, 2020
@jasnell @targos
src: return undefined when validation err == 0
b3f0417 
Extracted from the QUIC PR. Not specific to QUIC even if the
behavior is currently only used there.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #33107
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@sam-github sam-github sam-github approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @nodejs-github-bot @sam-github @addaleax