Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasi: update start() to better match spec #33073

Merged
merged 2 commits into from
Apr 28, 2020
Merged

wasi: update start() to better match spec #33073

merged 2 commits into from
Apr 28, 2020

Commits on Apr 28, 2020

  1. wasi: rename __wasi_unstable_reactor_start() 

    Upstream WASI has renamed __wasi_unstable_reactor_start() to
_initialize(). This commit updates Node's WASI implementation to
reflect that change.

PR-URL: nodejs#33073
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
    @cjihrig
    cjihrig committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    4791ea0 View commit details
    Browse the repository at this point in the history

  2. wasi: update start() behavior to match spec 

    _start() and _initialize() shouldn't be called from the same
function, as they have different behavior. Furthermore, Node
should throw if both are provided. This commit updates the
implementation, docs, and tests accordingly.

PR-URL: nodejs#33073
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
    @cjihrig
    cjihrig committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    6ca6db1 View commit details
    Browse the repository at this point in the history