Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix markdown parsing on doc/api/os.md #33067

Closed
wants to merge 1 commit into from
Closed

doc: fix markdown parsing on doc/api/os.md #33067

wants to merge 1 commit into from

Conversation

juanarbol
Copy link
Member

Something is wrong on MD parsing

Screenshot from 2020-04-25 17-33-23

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem. labels Apr 25, 2020
rexagod
rexagod reviewed Apr 26, 2020
View reviewed changes
Copy link
Member

@rexagod rexagod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit odd. Was this due to an invalid character?

@juanarbol
Copy link
Member Author

juanarbol commented Apr 27, 2020 •
edited
Loading

It looks like, I guess it is something with my code editor and space character, this had happened to me few times.

For this fix, I have built docs and check that fixed now.

addaleax
addaleax approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it might be worth investigating why a nbsp breaks this, it really shouldn’t do that

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2020
addaleax pushed a commit that referenced this pull request Apr 29, 2020
@juanarbol @addaleax
doc: fix markdown parsing on doc/api/os.md
ed87433 
PR-URL: #33067
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@addaleax
Copy link
Member

Landed in ed87433

@addaleax addaleax closed this Apr 29, 2020
targos pushed a commit that referenced this pull request May 4, 2020
@juanarbol @targos
doc: fix markdown parsing on doc/api/os.md
c5a2f9a 
PR-URL: #33067
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request May 4, 2020
Merged
@juanarbol juanarbol deleted the juanarbol/fix-osversion-docs branch January 19, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@MrHeer MrHeer MrHeer approved these changes

@rexagod rexagod rexagod approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@juanarbol @addaleax @Trott @MrHeer @rexagod @targos @nodejs-github-bot