-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update ESLint to 7.0.0-rc.0 #33062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
unfortunately, I cannot use |
@joyeecheung ^ How do you handle this? |
@targos It is caused by ISP issues, I usually just switch to another ISP (e.g. tethering through my phone because my mobile ISP blocks less), or use VPN on my computer. For git commands, git takes global proxy settings through |
PR-URL: #33062 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
landed in 039c5e4 |
PR-URL: #33062 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #33062 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #33062 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #33062 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
I mostly wanted to update eslint, cause this's my first time.
Using
update-eslint.sh
, I think I've well done thisChecklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes