Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 7.0.0-rc.0 #33062

Closed
wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

I mostly wanted to update eslint, cause this's my first time.

Using update-eslint.sh, I think I've well done this

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 25, 2020
@nodejs-github-bot
Copy link
Collaborator

@himself65 himself65 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 26, 2020
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@himself65
Copy link
Member Author

unfortunately, I cannot use git-node to land PR for now, cause it does not support system proxy 😟

@targos
Copy link
Member

targos commented Apr 27, 2020

@joyeecheung ^ How do you handle this?

@joyeecheung
Copy link
Member

@targos It is caused by ISP issues, I usually just switch to another ISP (e.g. tethering through my phone because my mobile ISP blocks less), or use VPN on my computer.

For git commands, git takes global proxy settings through ~/.gitconfig but git-node also have usual HTTPS requests to GitHub - these are not blocked the same way, some times connections to GitHub's git servers work while connections to some parts of github.com don't. Some people use tools like https://www.proxifier.com/ to redirect all TCP/UDP traffic in the system through a SOCKS5 server (I have not tried it). I guess we can also try adding proxy support to git-node (I see that there is already a feature request nodejs/node-core-utils#407)

himself65 added a commit that referenced this pull request Apr 28, 2020
PR-URL: #33062
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@himself65
Copy link
Member Author

landed in 039c5e4

@himself65 himself65 closed this Apr 28, 2020
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
PR-URL: #33062
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 28, 2020
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
PR-URL: #33062
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2020
PR-URL: #33062
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request May 13, 2020
PR-URL: #33062
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants