issue-link js-issue-link" data-error-text="Failed to load title" data-id="570192668" data-permission-text="Title is private" data-url="https://github.com/nodejs/node/issues/31940" data-hovercard-type="pull_request" data-hovercard-url="/nodejs/node/pull/31940/hovercard" href="https://github.com/nodejs/node/pull/31940">nodejs#31940 which has caused lots of unnecessary breakage in the ecosystem. This PR also aligns better with the actual documented behavior: `stream.pipeline()` will call `stream.destroy(err)` on all streams except: * `Readable` streams which have emitted `'end'` or `'close'`. * `Writable` streams which have emitted `'finish'` or `'close'`. The behavior introduced in nodejs#31940 was much more aggressive in terms of destroying streams. This was good for avoiding potential resources leaks however breaks some common assumputions in legacy streams. Furthermore, it makes the code simpler and removes some hacks. Fixes: nodejs#32954 Fixes: nodejs#32955

Commits

Commits on Apr 21, 2020

stream: pipeline should only destroy un-finished streams.

fixup: test

fixup: simplify

fixup: unnecessary once