http2: wait for secureConnect before initializing #32958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
http2
bcoe
requested review from
jasnell and
addaleax
and removed request for
jasnell
This comment has been minimized.
This comment has been minimized.
bcoe
added
the
author ready
jasnell
approved these changes
Apr 21, 2020
addaleax
approved these changes
Apr 21, 2020
bcoe
commented
Apr 21, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bcoe
added a commit
that referenced
this pull request
Apr 23, 2020
PR-URL: #32958 Fixes: #32922 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in 6a07eca |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
PR-URL: #32958 Fixes: #32922 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32958 Fixes: #32922 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 30, 2020
PR-URL: #32958 Fixes: #32922 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
davedoesdev
reviewed
May 1, 2020
| @@ -464,6 +464,7 @@ function TLSSocket(socket, opts) { | |||
| this._securePending = false; | |||
| this._newSessionPending = false; | |||
| this._controlReleased = false; | |||
| this.secureConnecting = true; | |||
There was a problem hiding this comment.
This is never set to false on client sockets.
So if Http2Session constructor (in lib/internal/http2/core.js) is called after secureConnect is emitted, then secureConnecting is still true but it'll end up never calling setupHandle and connect will never be emitted.
targos
pushed a commit
that referenced
this pull request
May 13, 2020
PR-URL: #32958 Fixes: #32922 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @murgatroid99 points out in #32922, a connection may have its
connectingproperty set totrue, while TLS is still connecting. This results insetupFn()being fired before the connection is actually ready.This PR introduces the property
secureConnectingonTLSSocket, which will not be set totrueuntil thesecureConnectionevent is emitted.Fixes: #32922
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes