Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: check args on SourceTextModule cachedData #32956

Closed
wants to merge 1 commit into from
Closed

test: check args on SourceTextModule cachedData #32956

wants to merge 1 commit into from

Conversation

juanarbol
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 20, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31036/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31074/

@addaleax
Copy link
Member

Landed in 766b3c1

@addaleax addaleax closed this Apr 29, 2020
addaleax pushed a commit that referenced this pull request Apr 29, 2020
@juanarbol @addaleax
test: check args on SourceTextModule cachedData
766b3c1 
PR-URL: #32956
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
targos pushed a commit that referenced this pull request May 4, 2020
@juanarbol @targos
test: check args on SourceTextModule cachedData
92c7e06 
PR-URL: #32956
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@targos targos mentioned this pull request May 4, 2020
Merged
targos pushed a commit that referenced this pull request May 7, 2020
@juanarbol @targos
test: check args on SourceTextModule cachedData
852ca0e 
PR-URL: #32956
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@targos targos mentioned this pull request May 7, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@juanarbol @targos
test: check args on SourceTextModule cachedData
3015887 
PR-URL: #32956
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@juanarbol juanarbol deleted the juanarbol/code-cov-vm branch January 19, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juanarbol @nodejs-github-bot @addaleax @devsnek