Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in security-release-process.md #32926

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in security-release-process.md #32926

wants to merge 1 commit into from

Conversation

SASUKE40
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 19, 2020
@SASUKE40 SASUKE40 changed the title doc: fix typos in security-release-process.md doc: fix typo in security-release-process.md Apr 20, 2020
juanarbol
juanarbol approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@juanarbol juanarbol added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30871/

juanarbol pushed a commit that referenced this pull request Apr 21, 2020
@SASUKE40 @juanarbol
doc: fix typo in security-release-process.md
438514d 
PR-URL: #32926
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@juanarbol
Copy link
Member

Amazing, nice job.

Landed in 438514d 🎉

@juanarbol juanarbol closed this Apr 21, 2020
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@SASUKE40 @BethGriggs
doc: fix typo in security-release-process.md
f6be140 
PR-URL: #32926
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@SASUKE40 @BridgeAR
doc: fix typo in security-release-process.md
8c48d16 
PR-URL: #32926
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
Merged
targos pushed a commit that referenced this pull request Apr 30, 2020
@SASUKE40 @targos
doc: fix typo in security-release-process.md
4f3c7b3 
PR-URL: #32926
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@targos targos mentioned this pull request May 2, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@SASUKE40 @targos
doc: fix typo in security-release-process.md
931c0c7 
PR-URL: #32926
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHeer MrHeer MrHeer approved these changes

@juanarbol juanarbol juanarbol approved these changes

@himself65 himself65 himself65 approved these changes

@devnexen devnexen devnexen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SASUKE40 @nodejs-github-bot @juanarbol @jasnell @cjihrig @devnexen @himself65 @MrHeer