Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs : update validateOffsetLengthRead in utils.js #32896

Closed
wants to merge 3 commits into from

Conversation

daemon1024
Copy link
Contributor

@daemon1024 daemon1024 commented Apr 17, 2020

Fixes : #32871

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Apr 17, 2020
@daemon1024
Copy link
Contributor Author

daemon1024 commented Apr 17, 2020

message: 'The value of "offset" is out of range. It must be >= 0 && <= 4. ' +

'It must be >= 0 && <= 4. Received -1'

'It must be >= 0 && <= 4. Received -1'

'It must be >= 0 && <= 4. Received -1'

Updating these in test/parallel/test-fs-read-type.js accordingly

Copy link
Member

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test case for <= ${bufferLength - offset}

Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nodejs-github-bot
Copy link
Collaborator

@puzpuzpuz
Copy link
Member

puzpuzpuz commented Apr 23, 2020

Landed in 1cc1ca4

Thanks for this improvement!

@puzpuzpuz puzpuzpuz closed this Apr 23, 2020
puzpuzpuz pushed a commit that referenced this pull request Apr 23, 2020
PR-URL: #32896
Fixes: #32871
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
PR-URL: #32896
Fixes: #32871
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 27, 2020
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
PR-URL: #32896
Fixes: #32871
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
targos pushed a commit that referenced this pull request Apr 30, 2020
PR-URL: #32896
Fixes: #32871
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
targos pushed a commit that referenced this pull request May 13, 2020
PR-URL: #32896
Fixes: #32871
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error message in fs.utils
6 participants