Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: corrected ERR_SOCKET_CANNOT_SEND message #32847

Closed
wants to merge 1 commit into from
Closed

doc: corrected ERR_SOCKET_CANNOT_SEND message #32847

wants to merge 1 commit into from

Conversation

willarmiros
Copy link
Contributor

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Apr 14, 2020
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 15, 2020
juanarbol
juanarbol approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30870/

juanarbol pushed a commit that referenced this pull request Apr 21, 2020
@willarmiros @juanarbol
doc: corrected ERR_SOCKET_CANNOT_SEND message
4299e97 
PR-URL: #32847
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@juanarbol
Copy link
Member

Landed in 4299e97 🎉

@juanarbol juanarbol closed this Apr 21, 2020
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@willarmiros @BethGriggs
doc: corrected ERR_SOCKET_CANNOT_SEND message
fa71073 
PR-URL: #32847
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@willarmiros @BridgeAR
doc: corrected ERR_SOCKET_CANNOT_SEND message
faeb408 
PR-URL: #32847
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@willarmiros @nodejs-github-bot @juanarbol @Trott @cjihrig @BridgeAR @targos