Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark test-worker-prof flaky on arm #32826

Closed
wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

Refs: #26401 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 13, 2020
@nodejs-github-bot
Copy link
Collaborator

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

fast-track?

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 14, 2020
@nodejs-github-bot
Copy link
Collaborator

@sam-github
Copy link
Contributor Author

I'm OK with fast-tracking, but the CI failed on unrelated tests :-(. Resumed it.

@sam-github
Copy link
Contributor Author

Landed in afae925

@sam-github sam-github closed this Apr 14, 2020
sam-github added a commit that referenced this pull request Apr 14, 2020
Refs: #26401 (comment)

PR-URL: #32826
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@sam-github sam-github deleted the flaky-worker-prof branch April 14, 2020 17:59
MylesBorins pushed a commit that referenced this pull request Apr 17, 2020
Refs: #26401 (comment)

PR-URL: #32826
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
Refs: nodejs#26401 (comment)

PR-URL: nodejs#32826
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
Refs: #26401 (comment)

PR-URL: #32826
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
targos pushed a commit that referenced this pull request Apr 28, 2020
Refs: #26401 (comment)

PR-URL: #32826
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants