Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: updated directory entry information #32791

Closed
wants to merge 1 commit into from

Conversation

el5846
Copy link
Contributor

@el5846 el5846 commented Apr 12, 2020

Fixes: #25595

[x] make -j4 test (UNIX), or vcbuild test (Windows) passes
[x] documentation is changed or added
[x] commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Apr 12, 2020
doc/api/fs.md Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Apr 12, 2020

Welcome, @el5846, and thanks for the pull request! Just want to repeat what I said in the other pull request, which is that documentation pull requests can attract a lot of comments. Please be patient with us! Thanks!

doc/api/fs.md Show resolved Hide resolved
doc/api/fs.md Outdated Show resolved Hide resolved
Fixes: nodejs#25595

subdirectory

updated def
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 17, 2020
@addaleax
Copy link
Member

@el5846 Sorry for the delay here!

Landed in ff622a2, and thanks for your pull request! 🎉

@addaleax addaleax closed this Apr 24, 2020
addaleax pushed a commit that referenced this pull request Apr 24, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 27, 2020
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request May 13, 2020
Fixes: #25595

subdirectory

updated def

PR-URL: #32791
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Dirent definition doesn't tell me anything useful about Dirent
4 participants