Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document buffer.from returns internal pool buffer #32703

Closed
wants to merge 3 commits into from
Closed

doc: document buffer.from returns internal pool buffer #32703

wants to merge 3 commits into from

Conversation

HarshithaKP
Copy link
Member

Fixes: #22139

Co-authored-by: Mritunjay Goutam [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Apr 7, 2020
@HarshithaKP
Copy link
Member Author

This is a re-work of stalled PR #24312.

@addaleax
Copy link
Member

addaleax commented Apr 7, 2020

Buffer.from(string) also does this.

@HarshithaKP
Copy link
Member Author

Buffer.from(string) also does this.

@addaleax, PTAL.

Trott
Trott reviewed Apr 7, 2020
View reviewed changes
doc/api/buffer.md Outdated Show resolved Hide resolved
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 7, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30615/

@addaleax
Copy link
Member

Landed in 2f755ff

@addaleax addaleax closed this Apr 13, 2020
addaleax pushed a commit that referenced this pull request Apr 13, 2020
@HarshithaKP @addaleax
doc: document buffer.from returns internal pool buffer
2f755ff 
Fixes: #22139

Co-authored-by: Mritunjay Goutam <[email protected]>

PR-URL: #32703
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@HarshithaKP HarshithaKP mentioned this pull request Apr 13, 2020
Closed
2 tasks
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@HarshithaKP @BethGriggs
doc: document buffer.from returns internal pool buffer
a7c75f9 
Fixes: #22139

Co-authored-by: Mritunjay Goutam <[email protected]>

PR-URL: #32703
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 14, 2020
Merged
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@HarshithaKP @targos
doc: document buffer.from returns internal pool buffer
1ba4afb 
Fixes: nodejs#22139

Co-authored-by: Mritunjay Goutam <[email protected]>

PR-URL: nodejs#32703
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@HarshithaKP @BridgeAR
doc: document buffer.from returns internal pool buffer
ea09c0f 
Fixes: #22139

Co-authored-by: Mritunjay Goutam <[email protected]>

PR-URL: #32703
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
Merged
targos pushed a commit that referenced this pull request Apr 28, 2020
@HarshithaKP @targos
doc: document buffer.from returns internal pool buffer
fa51d85 
Fixes: #22139

Co-authored-by: Mritunjay Goutam <[email protected]>

PR-URL: #32703
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request May 2, 2020
Merged
@puzpuzpuz puzpuzpuz mentioned this pull request Oct 7, 2020
Closed
3 tasks
puzpuzpuz added a commit that referenced this pull request Oct 14, 2020
@puzpuzpuz
doc: document Buffer.concat may use internal pool
ef1645e 
PR-URL: #35541
Refs: #32703
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
@puzpuzpuz @MylesBorins
doc: document Buffer.concat may use internal pool
0c87776 
PR-URL: #35541
Refs: #32703
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@puzpuzpuz @MylesBorins
doc: document Buffer.concat may use internal pool
54a29f1 
PR-URL: #35541
Refs: #32703
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@puzpuzpuz @MylesBorins
doc: document Buffer.concat may use internal pool
df52814 
PR-URL: #35541
Refs: #32703
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@puzpuzpuz @joesepi
doc: document Buffer.concat may use internal pool
8d03adb 
PR-URL: nodejs#35541
Refs: nodejs#32703
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buffer documentation on pooling might be misleading
6 participants
@HarshithaKP @addaleax @nodejs-github-bot @jasnell @Trott @lpinca