doc: remove warning from response.writeHead
#32700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example referenced as being potentially unsafe specifies Content-Length correctly.
nodejs-github-bot
added
doc
addaleax
approved these changes
Apr 7, 2020
|
@addaleax sounds good. Updated with that language & link. |
jasnell
approved these changes
Apr 7, 2020
lpinca
approved these changes
Apr 7, 2020
Flarna
approved these changes
Apr 7, 2020
Flarna
pushed a commit
that referenced
this pull request
Apr 13, 2020
The example referenced as being potentially unsafe specifies Content-Length correctly. PR-URL: #32700 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
|
Landed in 61e589f |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 14, 2020
The example referenced as being potentially unsafe specifies Content-Length correctly. PR-URL: #32700 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
The example referenced as being potentially unsafe specifies Content-Length correctly. PR-URL: nodejs#32700 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
The example referenced as being potentially unsafe specifies Content-Length correctly. PR-URL: #32700 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
The example referenced as being potentially unsafe specifies Content-Length correctly. PR-URL: #32700 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example referenced as being potentially unsafe specifies Content-Length correctly.
The current documentation warns that the example preceding this note only works because the characters in
"hello world"are all single-byte characters. The example however already usesBuffer.byteLength, which is the recommended "fix".Checklist