test: replace console.log/error with debuglog #32695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Apr 6, 2020
agustindaguerre
force-pushed
the
debug-test
branch
from
9b63eb6
to
d110688
Compare
|
Just a nit... the commit should use |
|
@jasnell updated 👍 |
This comment has been minimized.
This comment has been minimized.
agustindaguerre
force-pushed
the
debug-test
branch
from
d110688
to
20af0a4
Compare
This comment has been minimized.
This comment has been minimized.
himself65
added
the
author ready
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I'm sure this PR is ok but, I don't now why CI failed so many times(I'm a newbie on Jenkins CI) 🤔 |
This comment has been minimized.
This comment has been minimized.
Use utility debug logs instead of console logs in test-cluster-setup-master-multiple.js Refs: nodejs#32678
agustindaguerre
force-pushed
the
debug-test
branch
from
20af0a4
to
c993c4b
Compare
himself65
approved these changes
Apr 9, 2020
|
I will handle merging this |
|
@himself65 cool, thanks |
himself65
pushed a commit
that referenced
this pull request
Apr 9, 2020
Use utility debug logs instead of console logs in test-cluster-setup-master-multiple.js Refs: #32678 PR-URL: #32695 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
|
Landed in 41b1e87 Thanks for your contributions!🎉 |
|
BTW, the original commit message is invalid because ✖ da7d991c0221b662bf56a8d4861353237b84047e
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✖ 1:72 Line should be <= 72 columns. line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 5:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-lengthso I edit it manually |
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
Use utility debug logs instead of console logs in test-cluster-setup-master-multiple.js Refs: #32678 PR-URL: #32695 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 14, 2020
Use utility debug logs instead of console logs in test-cluster-setup-master-multiple.js Refs: #32678 PR-URL: #32695 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Use utility debug logs instead of console logs in test-cluster-setup-master-multiple.js Refs: #32678 PR-URL: #32695 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use utility debug logs instead of console logs in
test-cluster-setup-master-multiple.jsRefs: #32678
Checklist
make -j4 test(UNIX)