doc: enable remark-lint-no-literal-urls #32676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
nschonni
force-pushed
the
remarklint-no-literal-urls
branch
from
34fa5e0
to
d2849c4
Compare
nschonni
commented
Apr 6, 2020
| @@ -88,6 +88,6 @@ information described. | |||
| * [ ] Make sure the PRs for the vulnerabilities are closed. | |||
|
|
|||
| [H1 CVE requests]: https://hackerone.com/nodejs/cve_requests | |||
| [docker-node]: https://github.com/nodejs/docker-node/issues) | |||
There was a problem hiding this comment.
These anchor links were incorrect with trailing bracket
README.md
Outdated
| @@ -152,392 +152,428 @@ For information about the governance of the Node.js project, see | |||
| ### TSC (Technical Steering Committee) | |||
|
|
|||
| * [addaleax](https://github.com/addaleax) - | |||
| **Anna Henningsen** <[email protected]> (she/her) | |||
| **Anna Henningsen** [[email protected]](mailto:[email protected]) (she/her) | |||
There was a problem hiding this comment.
If the mailto format isn't prefered here, the rule could be disabled at the file level
There was a problem hiding this comment.
I think node-core-utils might parse these lines of the README file for some operations. If I'm not wrong about that, then that would need to be tested.
There was a problem hiding this comment.
any idea how to test this or who to ping? I'm also good with just disabling at the file or block level
There was a problem hiding this comment.
You could attempt to use node-core-utils to land a PR?
The parsing is done in https://github.com/nodejs/node-core-utils/blob/master/lib/collaborators.js.
There was a problem hiding this comment.
To avoid conflicts with the tooling, I've disabled the rule at the top of the README and reverted these changes.
I didn't actually test to see if there was an issue with the tool
nschonni
added a commit
to nschonni/remark-preset-lint-node
that referenced
this pull request
Apr 6, 2020
Upstream PR to fix nodejs/node#32676
|
@nschonni Am I correct that these are the reasons for doing this?:
Anything else? |
|
That seems to cover it @Trott. It also makes it explicit when you leave bare links that should be in code blocks like |
nschonni
force-pushed
the
remarklint-no-literal-urls
branch
from
d2849c4
to
e0f90bb
Compare
|
Rebased for conflict |
reflowed for line length after increased url size
Membership lists are currently formatted in a specific way for tooling
nschonni
force-pushed
the
remarklint-no-literal-urls
branch
from
e0f90bb
to
8b047bc
Compare
nschonni
added a commit
to nschonni/remark-preset-lint-node
that referenced
this pull request
Apr 23, 2020
Upstream PR to fix nodejs/node#32676
Trott
approved these changes
Apr 24, 2020
Trott
added
the
author ready
Trott
pushed a commit
that referenced
this pull request
Apr 24, 2020
PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
Trott
pushed a commit
that referenced
this pull request
Apr 24, 2020
PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
Trott
pushed a commit
that referenced
this pull request
Apr 24, 2020
reflowed for line length after increased url size PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
Trott
pushed a commit
that referenced
this pull request
Apr 24, 2020
Membership lists are currently formatted in a specific way for tooling PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
|
Landed in e99ec39...0619b60 |
Trott
pushed a commit
to nodejs/remark-preset-lint-node
that referenced
this pull request
Apr 24, 2020
Upstream PR to fix nodejs/node#32676
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
Membership lists are currently formatted in a specific way for tooling PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
reflowed for line length after increased url size PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
Membership lists are currently formatted in a specific way for tooling PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
reflowed for line length after increased url size PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
Membership lists are currently formatted in a specific way for tooling PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
reflowed for line length after increased url size PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
Membership lists are currently formatted in a specific way for tooling PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2020
PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2020
PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2020
reflowed for line length after increased url size PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2020
Membership lists are currently formatted in a specific way for tooling PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
reflowed for line length after increased url size PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
Membership lists are currently formatted in a specific way for tooling PR-URL: #32676 Reviewed-By: Rich Trott <[email protected]>
Marlyfleitas
added a commit
to Marlyfleitas/Node-remark-preset-lint
that referenced
this pull request
Aug 26, 2022
Upstream PR to fix nodejs/node#32676
patrickm68
added a commit
to patrickm68/Node-preset-lint
that referenced
this pull request
Sep 14, 2023
Upstream PR to fix nodejs/node#32676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes