Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make sure that inspector tests finish #32673

Closed
wants to merge 1 commit into from
Closed

test: make sure that inspector tests finish #32673

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Apr 5, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 5, 2020
@addaleax addaleax added the inspector Issues and PRs related to the V8 inspector protocol label Apr 5, 2020
eugeneo
eugeneo approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 6, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30500/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30511/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30543/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30548/

@addaleax
Copy link
Member Author

addaleax commented Apr 8, 2020

Landed in e2ea73a

@addaleax addaleax closed this Apr 8, 2020
addaleax added a commit that referenced this pull request Apr 8, 2020
@addaleax
test: make sure that inspector tests finish
e2ea73a 
PR-URL: #32673
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax deleted the inspector-tests branch April 8, 2020 14:43
targos pushed a commit that referenced this pull request Apr 12, 2020
@addaleax @targos
test: make sure that inspector tests finish
756a049 
PR-URL: #32673
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@addaleax @BethGriggs
test: make sure that inspector tests finish
d0b6ada 
PR-URL: #32673
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@addaleax @targos
test: make sure that inspector tests finish
bc9453a 
PR-URL: #32673
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugeneo eugeneo eugeneo approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@addaleax @nodejs-github-bot @eugeneo @jasnell @Trott @lpinca @targos @cjihrig