doc: correct version metadata for Readable.from #32639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
I've got 10.17.0 by looking at the changelogs, but I have only personally tested it's present in 10.19.0. |
richardlau
reviewed
Apr 3, 2020
doc/api/stream.md
Outdated
| @@ -1670,7 +1670,7 @@ failure, this can cause event listener leaks and swallowed errors. | |||
|
|
|||
| ### `stream.Readable.from(iterable, [options])` | |||
| <!-- YAML | |||
| added: v12.3.0 | |||
| added: v10.17.0 | |||
There was a problem hiding this comment.
@nodejs/documentation What's the correct metadata here? Can we have multiple added: entries (for each release line)? This API never went into a Node.js 11.x release.
There was a problem hiding this comment.
Yes. We should have multiple added: entries:
Suggested change
| added: v10.17.0 | |
| added: | |
| - v12.3.0 | |
| - v10.17.0 |
kzar
force-pushed
the
32638-readable-from-version
branch
from
5ded467 to
d82758f
Compare
jasnell
approved these changes
Apr 3, 2020
addaleax
approved these changes
Apr 3, 2020
|
Feel free to 👍 this comment to approve fast-tracking |
Merged
lpinca
approved these changes
Apr 3, 2020
|
Landed in 8c0a17a |
addaleax
pushed a commit
that referenced
this pull request
Apr 5, 2020
PR-URL: #32639 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 6, 2020
PR-URL: #32639 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
PR-URL: #32639 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
PR-URL: #32639 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
PR-URL: #32639 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please also see the corresponding issue for more background: #32638
Checklist