Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: updating Ninja guide #32629

Closed
wants to merge 1 commit into from
Closed

doc: updating Ninja guide #32629

wants to merge 1 commit into from

Conversation

edsadr
Copy link
Member

@edsadr edsadr commented Apr 3, 2020

This PR updates the guide to use Ninja, because the instructions were outdated after merging this PR

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 3, 2020
mmarchini
mmarchini reviewed Apr 3, 2020
View reviewed changes
doc/guides/building-node-with-ninja.md Outdated Show resolved Hide resolved
doc/guides/building-node-with-ninja.md Outdated Show resolved Hide resolved
Trott
Trott approved these changes Apr 5, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few style suggestions, but content LGTM.

@edsadr
Copy link
Member Author

edsadr commented Apr 6, 2020

Thanks for the review and the amazing suggestions @Trott , I just applied them and I guess this is ready :)

@Trott
Copy link
Member

Trott commented Apr 6, 2020

Landed in fd2b35c

Trott pushed a commit that referenced this pull request Apr 6, 2020
@edsadr @Trott
doc: update Ninja information in build guide
fd2b35c 
PR-URL: #32629
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@Trott Trott closed this Apr 6, 2020
@edsadr edsadr deleted the edsadr/ninja-guide branch April 7, 2020 15:14
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@edsadr @BethGriggs
doc: update Ninja information in build guide
cd73828 
PR-URL: #32629
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@edsadr @targos
doc: update Ninja information in build guide
c1bb041 
PR-URL: #32629
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@edsadr @targos
doc: update Ninja information in build guide
9039c03 
PR-URL: #32629
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmarchini mmarchini mmarchini left review comments

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@jvelezpo jvelezpo jvelezpo approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@sam-github sam-github Awaiting requested review from sam-github

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@edsadr @Trott @sam-github @addaleax @jvelezpo @gengjiawen @mmarchini @nodejs-github-bot