doc: fix more broken links #32586
Closed
doc: fix more broken links #32586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Test link definitions too - Report all broken links in a file, not just the first one - Avoid use of workers (launching ~90 workers has substantial overhead, and in my 4-core machine it is slower than not using them at all) & other simplifications Refs: nodejs#32359
Fix broken links found by the checker, and exclude test/fixtures as it contains invalid links. Also exclude doc/changelogs because they're huge files which take very long to parse, and (IIRC) are auto-generated anyway. (Oh and also a nit at the README next to my link)
nodejs-github-bot
added
doc
|
(Btw I attempted to check HTTP links too, and it takes about 10 seconds. Problem is, we have ~400 of them and Github just starts returning 429 after some point 😔) |
addaleax
approved these changes
Mar 31, 2020
cjihrig
approved these changes
Mar 31, 2020
jasnell
approved these changes
Mar 31, 2020
aduh95
approved these changes
Apr 1, 2020
mildsunrise
added
the
author ready
|
Landed in 9800732...882b61a |
mildsunrise
added a commit
that referenced
this pull request
Apr 2, 2020
- Test link definitions too - Report all broken links in a file, not just the first one - Avoid use of workers (launching ~90 workers has substantial overhead, and in my 4-core machine it is slower than not using them at all) & other simplifications Refs: #32359 PR-URL: #32586 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
mildsunrise
added a commit
that referenced
this pull request
Apr 2, 2020
Fix broken links found by the checker, and exclude test/fixtures as it contains invalid links. Also exclude doc/changelogs because they're huge files which take very long to parse, and (IIRC) are auto-generated anyway. (Oh and also a nit at the README next to my link) PR-URL: #32586 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
- Test link definitions too - Report all broken links in a file, not just the first one - Avoid use of workers (launching ~90 workers has substantial overhead, and in my 4-core machine it is slower than not using them at all) & other simplifications Refs: #32359 PR-URL: #32586 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
Fix broken links found by the checker, and exclude test/fixtures as it contains invalid links. Also exclude doc/changelogs because they're huge files which take very long to parse, and (IIRC) are auto-generated anyway. (Oh and also a nit at the README next to my link) PR-URL: #32586 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
- Test link definitions too - Report all broken links in a file, not just the first one - Avoid use of workers (launching ~90 workers has substantial overhead, and in my 4-core machine it is slower than not using them at all) & other simplifications Refs: #32359 PR-URL: #32586 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
Fix broken links found by the checker, and exclude test/fixtures as it contains invalid links. Also exclude doc/changelogs because they're huge files which take very long to parse, and (IIRC) are auto-generated anyway. (Oh and also a nit at the README next to my link) PR-URL: #32586 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
- Test link definitions too - Report all broken links in a file, not just the first one - Avoid use of workers (launching ~90 workers has substantial overhead, and in my 4-core machine it is slower than not using them at all) & other simplifications Refs: #32359 PR-URL: #32586 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Fix broken links found by the checker, and exclude test/fixtures as it contains invalid links. Also exclude doc/changelogs because they're huge files which take very long to parse, and (IIRC) are auto-generated anyway. (Oh and also a nit at the README next to my link) PR-URL: #32586 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes some improvements to the Markdown link checker from #32359:
doc/changelogsbecause they're huge files which take very long to parse, and (IIRC) are auto-generated anyway (this cuts out 90% of the time)Then fix the broken links, and exclude
test/fixturesas there's some invalid links there.Pinging @aduh95 as he wrote the tool :) Feel free to review, and if there's some detail I've missed from your code, tell me and I'll fix it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes