Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix wordy sentence #32567

Closed
wants to merge 1 commit into from
Closed

doc: fix wordy sentence #32567

wants to merge 1 commit into from

Conversation

NotMoni
Copy link
Contributor

@NotMoni NotMoni commented Mar 30, 2020

Checklist
  • [x ] documentation is changed or added
  • [ x] commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 30, 2020
@NotMoni NotMoni mentioned this pull request Mar 30, 2020
Closed
@addaleax
Copy link
Member

addaleax commented Apr 2, 2020

Landed in 1917ba8, thanks for the PR!

@addaleax addaleax closed this Apr 2, 2020
addaleax pushed a commit that referenced this pull request Apr 2, 2020
@NotMoni @addaleax
doc: fix wordy sentence
1917ba8 
PR-URL: #32567
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@NotMoni NotMoni deleted the patch-1 branch April 2, 2020 23:48
@NotMoni
Copy link
Contributor Author

NotMoni commented Apr 2, 2020

@addaleax No problem. Looking 👀 to do more in the future
:D

BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@NotMoni @BethGriggs
doc: fix wordy sentence
dc6c462 
PR-URL: #32567
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@NotMoni @targos
doc: fix wordy sentence
a1bb93a 
PR-URL: #32567
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@NotMoni @targos
doc: fix wordy sentence
7e952f2 
PR-URL: #32567
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
This was referenced Aug 31, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 12, 2021
Open
Open
@wedataintelligence wedataintelligence mentioned this pull request Dec 19, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Dec 19, 2023
Open
@kissofire kissofire mentioned this pull request Feb 11, 2024
Open
@137717unity 137717unity mentioned this pull request Feb 11, 2024
Open
@molllyn1 molllyn1 mentioned this pull request Feb 11, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Feb 11, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Feb 11, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Feb 12, 2024
Open
@baby636 baby636 mentioned this pull request Feb 12, 2024
Open
@molllyn1 molllyn1 mentioned this pull request Mar 22, 2024
Open
@137717unity 137717unity mentioned this pull request Mar 22, 2024
Open
@baby636 baby636 mentioned this pull request Mar 22, 2024
Open
@kissofire kissofire mentioned this pull request Mar 22, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Mar 22, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Mar 22, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Mar 23, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 13, 2024
Open
@molllyn1 molllyn1 mentioned this pull request May 13, 2024
Open
@ron-a20 ron-a20 mentioned this pull request May 13, 2024
Open
@kissofire kissofire mentioned this pull request May 13, 2024
Open
@137717unity 137717unity mentioned this pull request May 14, 2024
Open
@baby636 baby636 mentioned this pull request May 14, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request May 14, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 15, 2024
Open
@kissofire kissofire mentioned this pull request May 20, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 21, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request May 21, 2024
Open
@137717unity 137717unity mentioned this pull request May 21, 2024
Open
@molllyn1 molllyn1 mentioned this pull request May 21, 2024
Open
@ron-a20 ron-a20 mentioned this pull request May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshithaKP HarshithaKP HarshithaKP left review comments

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@NotMoni @addaleax @jasnell @Trott @lpinca @HarshithaKP @nodejs-github-bot