Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: use template strings in parallel tests #32549

Closed
wants to merge 1 commit into from
Closed

tests: use template strings in parallel tests #32549

wants to merge 1 commit into from

Conversation

dericop
Copy link
Contributor

@dericop dericop commented Mar 29, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 29, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 29, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/30182/ (:heavy_check_mark:)

addaleax pushed a commit that referenced this pull request Apr 2, 2020
@dericop @addaleax
test: use template strings in parallel tests
a6ab883 
PR-URL: #32549
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax
Copy link
Member

addaleax commented Apr 2, 2020

Landed in a6ab883 🎉

@addaleax addaleax closed this Apr 2, 2020
@addaleax
Copy link
Member

addaleax commented Apr 2, 2020

@dericop People who make consistent, valuable contributions to Node.js will be considered for being added as a collaborator. Basically, to keep contributing to Node.js is a good way to do that.

If that’s your goal, you may also want to keep a close eye on the issue tracker or watch this repository, to get a better idea of what’s happening and where you could help.

@dericop
Copy link
Contributor Author

dericop commented Apr 2, 2020 •
edited
Loading

Excelent! Thanks for the answer.

BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@dericop @BethGriggs
test: use template strings in parallel tests
d09171f 
PR-URL: #32549
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@dericop @targos
test: use template strings in parallel tests
cca269c 
PR-URL: #32549
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@dericop @targos
test: use template strings in parallel tests
a055244 
PR-URL: #32549
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dericop @nodejs-github-bot @addaleax @jasnell @Trott @cjihrig