Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-http2-buffersize #32540

Merged
merged 1 commit into from
Apr 5, 2020
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 29, 2020

Remove seemlingly misplaced and/or extraneous comment. Replace countdown
with Promise.all.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 29, 2020
test/parallel/test-http2-buffersize.js Outdated Show resolved Hide resolved
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 29, 2020

@addaleax addaleax added the review wanted PRs that need reviews. label Apr 2, 2020
Remove seemlingly misplaced and/or extraneous comment. Replace countdown
with Promise.all.

PR-URL: nodejs#32540
Reviewed-By: Anna Henningsen <[email protected]>
@Trott
Copy link
Member Author

Trott commented Apr 5, 2020

Landed in c452632

@Trott Trott merged commit c452632 into nodejs:master Apr 5, 2020
@Trott Trott deleted the refac-http2-bufsize branch April 5, 2020 06:02
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
Remove seemlingly misplaced and/or extraneous comment. Replace countdown
with Promise.all.

PR-URL: #32540
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
Remove seemlingly misplaced and/or extraneous comment. Replace countdown
with Promise.all.

PR-URL: #32540
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
Remove seemlingly misplaced and/or extraneous comment. Replace countdown
with Promise.all.

PR-URL: #32540
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants