Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: wait for shutdown to complete before closing #32491

Closed
wants to merge 6 commits into from
Closed

net: wait for shutdown to complete before closing #32491

wants to merge 6 commits into from

Commits on Mar 25, 2020

  1. net: wait for shutdown to complete before closing 

    When not allowing half open, handle.close would be
invoked before shutdown has been called and
completed causing a potential data race.

Fixes: nodejs#32486 (comment)
    @ronag
    ronag committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    3bf1c08 View commit details
    Browse the repository at this point in the history

  2. fixup: test

    @ronag
    ronag committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    93c6f75 View commit details
    Browse the repository at this point in the history

  3. fixup: test

    @ronag
    ronag committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    c485b6a View commit details
    Browse the repository at this point in the history

  4. fixup: tst

    @ronag
    ronag committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    871866e View commit details
    Browse the repository at this point in the history

  5. fixup: test

    @ronag
    ronag committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    fb389dc View commit details
    Browse the repository at this point in the history

  6. fixup: apply win10 fix

    @ronag
    ronag committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    a9382cb View commit details
    Browse the repository at this point in the history