Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test: mark empty udp tests flaky on OS X" #32489

Closed
wants to merge 1 commit into from
Closed

Revert "test: mark empty udp tests flaky on OS X" #32489

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Mar 25, 2020

This reverts commit 24a4f76.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 25, 2020
@lpinca
Copy link
Member Author

lpinca commented Mar 25, 2020

The issue seems to be fixed in macOS 10.15.4

@lpinca
Copy link
Member Author

lpinca commented Mar 25, 2020 •
edited
Loading

@nodejs/platform-macos @AshCripps

@lpinca lpinca requested a review from sam-github March 25, 2020 18:33
@sam-github
Copy link
Contributor

Are these the tests that just failed in https://ci.nodejs.org/job/node-test-commit-osx/32914/#showFailuresLink from the unrelated to UDP #32207 ?

If so, they are still flaky.

@lpinca
Copy link
Member Author

lpinca commented Mar 25, 2020

Yes, what is the macOS version on jenkins?

@lpinca
Copy link
Member Author

lpinca commented Mar 25, 2020

It seems to be 10.15.1, can it be updated to 10.15.4?

@AshCripps
Copy link
Member

The macs should be able to be updated, might be a bit disruptive.

This PR should be held off until the machines are updated.

@lpinca lpinca added the blocked PRs that are blocked by other issues or PRs. label Mar 25, 2020
@lpinca
Copy link
Member Author

lpinca commented Mar 25, 2020

Added blocked label.

@AshCripps AshCripps mentioned this pull request Mar 26, 2020
Closed
@AshCripps
Copy link
Member

https://ci.nodejs.org/job/node-test-commit-osx-AshCripps/10/nodes=test-nearform-macos10.15-x64-1/ passed with 10.15.4 but test.sequential/test-timers-blocking-callback failed again.

Now working on the other two machines

@AshCripps
Copy link
Member

@lpinca All 1015 macs currently in CI are now 10.15.4 feel free to remove the blocked label

@AshCripps
Copy link
Member

Will also need to be reverted on 12.x I believe

@lpinca lpinca removed the blocked PRs that are blocked by other issues or PRs. label Mar 26, 2020
@lpinca
Copy link
Member Author

lpinca commented Mar 26, 2020

Done, thank you.

@richardlau
Copy link
Member

richardlau commented Mar 27, 2020 •
edited
Loading

As of #32450 we're now testing on macOS with GitHub Actions and as far as I can tell the macOS runners are still macOS 10.15.3.

@richardlau richardlau added the blocked PRs that are blocked by other issues or PRs. label Mar 27, 2020
@lpinca
Copy link
Member Author

lpinca commented Mar 28, 2020

@richardlau it looks like tests marked as flaky are run, see https://github.com/nodejs/node/pull/32534/checks?check_run_id=541357985 so we should either unblock this or set FLAKY_TESTS to skip.

@lpinca
Copy link
Member Author

lpinca commented Mar 28, 2020

Nvm it's already set to dontcare.

@richardlau
Copy link
Member

We’ll still need to keep the tests marked as FLAKY (e.g. this is blocked) for either FLAKY_TESTS skip or dontcare.

@lpinca lpinca removed the blocked PRs that are blocked by other issues or PRs. label Apr 2, 2020
@lpinca
Copy link
Member Author

lpinca commented Apr 2, 2020

Removed "blocked" again as macOS runners now use 10.15.4

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30404/

lpinca added a commit that referenced this pull request Apr 6, 2020
@lpinca
Revert "test: mark empty udp tests flaky on OS X"
f675e3a 
This reverts commit 24a4f76.

PR-URL: #32489
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@lpinca
Copy link
Member Author

lpinca commented Apr 6, 2020

Landed in f675e3a.

@lpinca lpinca closed this Apr 6, 2020
@lpinca lpinca deleted the revert/24a4f767 branch April 6, 2020 16:30
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@lpinca @BethGriggs
Revert "test: mark empty udp tests flaky on OS X"
46f060c 
This reverts commit 24a4f76.

PR-URL: #32489
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@lpinca @targos
Revert "test: mark empty udp tests flaky on OS X"
9df274a 
This reverts commit 24a4f76.

PR-URL: #32489
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@lpinca @targos
Revert "test: mark empty udp tests flaky on OS X"
e417416 
This reverts commit 24a4f76.

PR-URL: #32489
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
richardlau pushed a commit that referenced this pull request Jul 1, 2020
@lpinca @richardlau
Revert "test: mark empty udp tests flaky on OS X"
3dbd8cd 
This reverts commit 24a4f76.

PR-URL: #32489
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@richardlau richardlau mentioned this pull request Jul 2, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@addaleax addaleax addaleax approved these changes

@sam-github sam-github Awaiting requested review from sam-github

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lpinca @sam-github @AshCripps @richardlau @nodejs-github-bot @addaleax @BethGriggs