stream: emit 'pause' on unpipe #32476
Conversation
unpipe should use pause() instead of mutating state.flowing directly so that pausing side effects such as emitting 'pause' are properly performed. Fixes: nodejs#32470
nodejs-github-bot
added
the
stream
|
Should we fast track this and get it included in v13.12.0? I don't know if it should so this should not count as 1 of the 2 +1s |
MylesBorins
added
the
fast-track
|
This doesn't have green CI yet. Maybe flaky test (test.parallel/test-tls-root-certificates)? I'll do a rerun/resume once it's complete (osx always takes time). I seem to be encountering quite a lot of flakiness nowadays. |
|
https://github.com/nodejs/build/issues/2252 |
|
@MylesBorins Does that mean I can land this on master without green CI or should I keep trying until green CI is achieved? |
|
@ronag kicked off CI again. We should try and get green CI |
unpipe should use pause() instead of mutating state.flowing directly so that pausing side effects such as emitting 'pause' are properly performed. Fixes: #32470 PR-URL: #32476 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
|
We did it!!! Landed in 0d0f151 |
unpipe should use pause() instead of mutating state.flowing directly so that pausing side effects such as emitting 'pause' are properly performed. Fixes: #32470 PR-URL: #32476 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
unpipe should use pause() instead of mutating
state.flowing directly so that pausing side
effects such as emitting 'pause' are properly
performed.
Fixes: #32470
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes