Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: fixup error message #32475

Closed
wants to merge 2 commits into from
Closed

console: fixup error message #32475

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 24, 2020

Use "options.inspectOptions" instead of just "inspectOptions"

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@jasnell
console: fixup error message
e93507d 
Use "options.inspectOptions" instead of just "inspectOptions"

Signed-off-by: James M Snell <[email protected]>
@nodejs-github-bot nodejs-github-bot added the console Issues and PRs related to the console subsystem. label Mar 24, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30038/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30057/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30074/

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 27, 2020
addaleax pushed a commit that referenced this pull request Mar 28, 2020
@jasnell @addaleax
console: fixup error message
05aa67a 
Use "options.inspectOptions" instead of just "inspectOptions"

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32475
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@addaleax
Copy link
Member

Landed in 05aa67a

@addaleax addaleax closed this Mar 28, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@jasnell @addaleax
console: fixup error message
814d88a 
Use "options.inspectOptions" instead of just "inspectOptions"

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32475
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@jasnell @targos
console: fixup error message
7908415 
Use "options.inspectOptions" instead of just "inspectOptions"

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32475
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. console Issues and PRs related to the console subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @nodejs-github-bot @addaleax @lpinca