Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: fixup options.method error message #32471

Closed
wants to merge 1 commit into from
Closed

http: fixup options.method error message #32471

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 24, 2020

Use options.method instead of just method in ERR_INVALID_ARG_TYPE

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Mar 24, 2020
@jasnell jasnell force-pushed the fixup-error-message-http-client branch from 068e55d to 1e861a9 Compare March 24, 2020 21:35
@jasnell
http: fixup options.method error message
59bf960 
Use `options.method` instead of just `method`

Signed-off-by: James M Snell <[email protected]>
@jasnell jasnell force-pushed the fixup-error-message-http-client branch from 1e861a9 to 59bf960 Compare March 24, 2020 21:43
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30034/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30054/

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2020
@addaleax
Copy link
Member

Landed in ca19d55

addaleax pushed a commit that referenced this pull request Mar 27, 2020
@jasnell @addaleax
http: fixup options.method error message
ca19d55 
Use `options.method` instead of just `method`

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32471
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@addaleax addaleax closed this Mar 27, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@jasnell @addaleax
http: fixup options.method error message
567b352 
Use `options.method` instead of just `method`

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32471
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@jasnell @targos
http: fixup options.method error message
52a52d2 
Use `options.method` instead of just `method`

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32471
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlucas evanlucas evanlucas approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @nodejs-github-bot @addaleax @evanlucas @trivikr