doc: fix lint warning in doc/api/esm.md #32462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Lau <[email protected]>
nodejs-github-bot
added
doc
lpinca
approved these changes
Mar 24, 2020
|
Upvote to fast-track. |
sam-github
added
the
fast-track
BethGriggs
approved these changes
Mar 24, 2020
richardlau
referenced
this pull request
Mar 24, 2020
PR-URL: #31479 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Myles Borins <[email protected]>
trivikr
approved these changes
Mar 24, 2020
MylesBorins
pushed a commit
that referenced
this pull request
Mar 24, 2020
Signed-off-by: Richard Lau <[email protected]> PR-URL: #32462 Refs: #31479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
Landed in 066bdec Apologies for not catching the error in the original PR |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 25, 2020
Signed-off-by: Richard Lau <[email protected]> PR-URL: #32462 Refs: #31479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Apr 3, 2020
Signed-off-by: Richard Lau <[email protected]> PR-URL: nodejs#32462 Refs: nodejs#31479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 3, 2020
Signed-off-by: Richard Lau <[email protected]> Backport-PR-URL: #32610 PR-URL: #32462 Refs: #31479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31479 landed on master with the following warning from the markdown linter:
https://github.com/nodejs/node/runs/531048109?check_suite_focus=true#step:4:6
Refs: #31479
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes