Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove a duplicated test #32453

Closed
wants to merge 1 commit into from
Closed

test: remove a duplicated test #32453

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

@himself65 himself65 commented Mar 24, 2020 •
edited
Loading

same tests

https://github.com/nodejs/node/blob/master/test/parallel/test-async-hooks-recursive-stack.js
https://github.com/nodejs/node/blob/master/test/parallel/test-async-hooks-recursive-stack-runInAsyncScope.js

9d06443 have remove deprecated emitBefore and emitAfter, but He didn't notice the duplicated tests

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 24, 2020
@himself65 himself65 changed the title test: remove a unused test test: remove a duplicated test Mar 24, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30188/

@addaleax
Copy link
Member

Landed in 9b4306d

addaleax pushed a commit that referenced this pull request Mar 29, 2020
@himself65 @addaleax
test: remove a duplicated test
9b4306d 
PR-URL: #32453
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@addaleax addaleax closed this Mar 29, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@himself65 @addaleax
test: remove a duplicated test
f179a22 
PR-URL: #32453
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@himself65 @targos
test: remove a duplicated test
df890ad 
PR-URL: #32453
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@antsmartian antsmartian antsmartian approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@himself65 @nodejs-github-bot @addaleax @jasnell @antsmartian @richardlau @BethGriggs @ZYSzys