test: use mustCall in place of countdown in timers test #32416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
lpinca
approved these changes
Mar 23, 2020
addaleax
approved these changes
Mar 23, 2020
|
Landed in 96f06e6 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 24, 2020
Use common.mustCall() in place of countdown in test-timers-immediate-unref. PR-URL: nodejs#32416 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 24, 2020
Use common.mustCall() in place of countdown in test-timers-immediate-unref. PR-URL: #32416 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 24, 2020
Use common.mustCall() in place of countdown in test-timers-immediate-unref. PR-URL: #32416 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Use common.mustCall() in place of countdown in test-timers-immediate-unref. PR-URL: #32416 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use common.mustCall() in place of countdown in
test-timers-immediate-unref.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes