Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make fs functions handle pre-epoch timestamps #32408

Closed
wants to merge 3 commits into from
Closed

src: make fs functions handle pre-epoch timestamps #32408

wants to merge 3 commits into from

Commits on Mar 21, 2020

  1. drop! libuv fs fixes

    @bnoordhuis
    bnoordhuis committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    083b4a5 View commit details
    Browse the repository at this point in the history

  2. lib: remove file timestamp rounding hack 

    Introduced in commit 9836cf5 ("lib: lazy instantiation of fs.Stats
dates") without providing any rationale - that wasn't added until later,
by someone else - and it doesn't look the least bit correct to me.

It certainly makes an upcoming regression test fail because a timestamp
in the deep past doesn't round-trip correctly, it's off by a fraction of
a second.

Refs: nodejs#32369
    @bnoordhuis
    bnoordhuis committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    a05e273 View commit details
    Browse the repository at this point in the history

  3. src: make fs functions handle pre-epoch timestamps 

    A wrong type cast prevented timestamps before 1970-01-01 from working
with functions like `fs.stat()`.

Fixes: nodejs#32369
    @bnoordhuis
    bnoordhuis committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    2a96f50 View commit details
    Browse the repository at this point in the history