src: enhance C++ sprintf utility #32385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
himself65
force-pushed
the
20200320-debug
branch
from
c58f428
to
1ee75ad
Compare
himself65
changed the title
himself65
force-pushed
the
20200320-debug
branch
2 times, most recently
from
43287bc
to
658075e
Compare
himself65
changed the title
himself65
force-pushed
the
20200320-debug
branch
4 times, most recently
from
ddba87b
to
f363ae5
Compare
addaleax
reviewed
Mar 20, 2020
| template <unsigned BASE_BITS, typename T> | ||
| std::string ToBaseString(T&& value, bool upper = false) { | ||
| return ToStringHelper::BaseConvert<BASE_BITS>(std::forward<T>(value), upper); | ||
| } |
There was a problem hiding this comment.
I don’t think you need to do any templating for T, any value that’s passed to a function like this will be convertible to unsigned long long anyway.
There was a problem hiding this comment.
Of course ok, but we had code more template for other types if we do this.
btw, I inspired from this https://github.com/fmtlib/fmt/blob/5d32ccfc3130fdd122c344b37087ac7fd8c2b62e/include/fmt/format.h#L901-L913
bnoordhuis
reviewed
Mar 20, 2020
himself65
force-pushed
the
20200320-debug
branch
from
f363ae5
to
24c4877
Compare
addaleax
approved these changes
Mar 20, 2020
himself65
force-pushed
the
20200320-debug
branch
from
24c4877
to
bd84d89
Compare
gabrielschulhof
approved these changes
Mar 21, 2020
|
Travis-ci fail because of timeout https://travis-ci.com/github/nodejs/node/jobs/300545913#L3154-L3159 |
jasnell
approved these changes
Mar 21, 2020
|
@himself65 I restarted the Travis job. |
gabrielschulhof
pushed a commit
that referenced
this pull request
Mar 26, 2020
PR-URL: #32385 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
|
Landed in dade90d. |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 26, 2020
PR-URL: #32385 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
Merged
2 tasks
2 tasks
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
PR-URL: #32385 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #32370
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes