-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quic: part 2... ngtcp2 and nghttp3 #32378
Conversation
This commit has two .gyp files in it, which are unique to Node.js (and have inconsistent indentation, if that matters). For maintainability, the commit adding the gyp files that we maintain should be split from the commit adding the upstream maintained source. The commit adding the upstream src should describe where it came from, and what version of the dep got vendored in (probably just a "curled from this URL (that includes a version), untarred, moved into place" is sufficient if it came from a released tarball. There should be commit adding a doc/guide/maintaining-ngXXX doc (one? two? as you think reasonable) that describes how to update these deps when they inevitably need updating. |
Will work those changes in @sam-github thank you :-) |
718a2b7
to
00bfcd9
Compare
ae9efc1
to
c6cc7d0
Compare
Updated to include maintenance instructions |
Putting all three of the PRs here on the tsc-agenda to queue up discussion on how we want to get these landed. |
00bfcd9
to
7afa9a8
Compare
c6cc7d0
to
88ea645
Compare
nodejs/quic master was rebased and sync'd with nodejs/master earlier today. The commits in the PR have been updated accordingly. |
7afa9a8
to
846b216
Compare
88ea645
to
28fbb81
Compare
846b216
to
0612442
Compare
28fbb81
to
9f13c4f
Compare
0612442
to
e96bea6
Compare
Signed-off-by: James M Snell <[email protected]>
Signed-off-by: James M Snell <[email protected]>
9f13c4f
to
813739b
Compare
This is the second of three separate PRs that would need to be landed together. They have been split to allow easier reviewing. This PR covers the addition of the ngtcp2 and nghttp3 dependencies to the source tree.
NOTE: This PR merges into the
initial-quic-part-1
branchThe other two PRs in this batch are:
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes