Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: clean v8 namespaces in env.cc file #32374

Closed
wants to merge 1 commit into from
Closed

src: clean v8 namespaces in env.cc file #32374

wants to merge 1 commit into from

Conversation

juanarbol
Copy link
Member

@juanarbol juanarbol commented Mar 19, 2020 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 19, 2020
mhdawson
mhdawson approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 23, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30001/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30017/

@mhdawson
Copy link
Member

Attempting rebuild: https://ci.nodejs.org/job/node-test-pull-request/30017/

@mhdawson
Copy link
Member

And again: https://ci.nodejs.org/job/node-test-pull-request/30068/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30068/

@mhdawson
Copy link
Member

Retry of just the failing sub-jobs

https://ci.nodejs.org/job/node-test-binary-windows-js-suites/2663/
https://ci.nodejs.org/job/node-test-commit-windows-fanned/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30123/

addaleax pushed a commit that referenced this pull request Mar 27, 2020
@juanarbol @addaleax
src: clean v8 namespaces in env.cc file
6791ac0 
PR-URL: #32374
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@addaleax
Copy link
Member

Landed in 6791ac0

@addaleax addaleax closed this Mar 27, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@juanarbol @addaleax
src: clean v8 namespaces in env.cc file
778dcc8 
PR-URL: #32374
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@juanarbol @targos
src: clean v8 namespaces in env.cc file
12d83b3 
PR-URL: #32374
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
@juanarbol juanarbol deleted the juanarbol/v8-namespaces branch January 19, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@devnexen devnexen devnexen approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@juanarbol @nodejs-github-bot @mhdawson @addaleax @jasnell @lpinca @devnexen